Rationale

Issue 1092 & 1096

1. Single quote url encoding is handled differently by different browsers, FF doesn't encode it but chrome does. This results in different filter values persisted in customview depending on the browser that the view is saved from. To match converted columns, a change is made to attempt both encoded and unencoded single quote when comparing names.
2. Filter values were not converted during column type conversion. The filter is either dropped, or the filter operator is updated only. This is problematic when converting between single and multi value filter types. For single filter, semicolon is not encoded, not special handled. For multi filter, depending on if any value contains semicolon, the filter value is either a special json array, or is a plain ; concatenated string. To avoid broken filters after field type conversion, the following change of behavior is introduced:

• For MVTC -> TC, arraymatches is converted to in, arraynotmatches is converted to notin, if the fitler value contains semicolon. If the value doesn't contain semicolon, they continue to convert to eq and neqornull, as before.
• For TC -> MVTC, if the filter value contains semicolon, the filter is dropped.

Related Pull Requests

Changes